<html>
<head><meta charset="utf-8"><title>highfive-bot mark certain prs as rollup=never or iffy · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/highfive-bot.20mark.20certain.20prs.20as.20rollup.3Dnever.20or.20iffy.html">highfive-bot mark certain prs as rollup=never or iffy</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="237645448"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/highfive-bot%20mark%20certain%20prs%20as%20rollup%3Dnever%20or%20iffy/near/237645448" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/highfive-bot.20mark.20certain.20prs.20as.20rollup.3Dnever.20or.20iffy.html#237645448">(May 06 2021 at 11:56)</a>:</h4>
<p>Prs that change run-make tests are really hard to debug in a rollup. Also these are tougher to spot for a person making the rollups as they have to check each PR closely which isn't always possible and we have to rely on the reviewers to mark them accordingly. </p>
<p>Was wondering if highfive bot (or any other bot <span aria-label="stuck out tongue" class="emoji emoji-1f61b" role="img" title="stuck out tongue">:stuck_out_tongue:</span> ) could mark a pr that changes run-make tests automatically as either <code>rollup=never</code> or even <code>rollup=iffy</code>the same way how it warns on submodule changes?</p>
<p>Context: <a href="https://github.com/rust-lang/rust/pull/84797#issuecomment-833450882">https://github.com/rust-lang/rust/pull/84797#issuecomment-833450882</a><br>
(cc <span class="user-mention" data-user-id="120791">@RalfJ</span> )</p>



<a name="237647011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/highfive-bot%20mark%20certain%20prs%20as%20rollup%3Dnever%20or%20iffy/near/237647011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> hyd-dev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/highfive-bot.20mark.20certain.20prs.20as.20rollup.3Dnever.20or.20iffy.html#237647011">(May 06 2021 at 12:09)</a>:</h4>
<p>The bootstrap change in that PR <em>also</em> looks suspicious because the error seems coming from bootstrap:<br>
<a href="https://github.com/rust-lang/rust/blob/24acc388da2cdbe1ec79b6933402941b6fffb26b/src/bootstrap/compile.rs#L687">https://github.com/rust-lang/rust/blob/24acc388da2cdbe1ec79b6933402941b6fffb26b/src/bootstrap/compile.rs#L687</a><br>
(there's <code>"-print-file-name=libstdc++.a"</code> in the failed command so I think it's coming from there)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>